security: harden ember-protocol input validation - #131
Merged
Conversation
…tor parsing eagerly - parse_f64 now rejects inf/-inf (was only rejecting NaN), making it consistent with parse_incrbyfloat which already had this check - parse_slot_list and parse_cluster_setslot now validate slot < 16384 - parse_vadd/parse_vsim check MAX_VECTOR_DIMS inside the loop instead of after full allocation, preventing unnecessary memory usage
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
…tor parsing eagerly (#131) - parse_f64 now rejects inf/-inf (was only rejecting NaN), making it consistent with parse_incrbyfloat which already had this check - parse_slot_list and parse_cluster_setslot now validate slot < 16384 - parse_vadd/parse_vsim check MAX_VECTOR_DIMS inside the loop instead of after full allocation, preventing unnecessary memory usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
parse_f64now rejectsinf/-infin addition toNaN, making it consistent withparse_incrbyfloatwhich already had this check. prevents infinite scores in sorted sets.parse_slot_listandparse_cluster_setslotnow validate that slot numbers are in the valid 0-16383 range. previously, any u16 value was accepted.parse_vadd/parse_vsimcheckMAX_VECTOR_DIMSinside the parsing loop instead of after full allocation, preventing unnecessary memory usage from oversized vectors.what was tested
cargo test -p ember-protocol— all 319 tests passparse_incrbyfloatstill worksdesign considerations
parse_f64matches redis behavior (redis rejectsinfas a ZADD score)